Skip to content

promote book with empty actions if possible#434

Merged
elfkuzco merged 1 commit into
mainfrom
promote-book-directly-prod
Jul 16, 2026
Merged

promote book with empty actions if possible#434
elfkuzco merged 1 commit into
mainfrom
promote-book-directly-prod

Conversation

@elfkuzco

Copy link
Copy Markdown
Contributor

Changes

  • remove restriction to reject promotion when there are no actions to perform
  • show button to promote book in UI when there are no actions to perform

This closes #429

@elfkuzco elfkuzco self-assigned this Jul 16, 2026
@elfkuzco
elfkuzco requested a review from benoit74 July 16, 2026 14:54
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.69%. Comparing base (19356da) to head (1b12b51).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   80.70%   80.69%   -0.02%     
==========================================
  Files          64       64              
  Lines        3705     3703       -2     
  Branches      438      437       -1     
==========================================
- Hits         2990     2988       -2     
  Misses        576      576              
  Partials      139      139              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco
elfkuzco force-pushed the promote-book-directly-prod branch from 5ebc661 to 1b12b51 Compare July 16, 2026 15:15
@elfkuzco
elfkuzco merged commit ce87dd1 into main Jul 16, 2026
7 checks passed
@elfkuzco
elfkuzco deleted the promote-book-directly-prod branch July 16, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directly move book to production when promotion has no action needed

2 participants