Quick fix for pollution of zimcheck output#1105
Open
veloman-yunkan wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
- Coverage 56.39% 46.85% -9.54%
==========================================
Files 100 94 -6
Lines 5050 4853 -197
Branches 2241 2104 -137
==========================================
- Hits 2848 2274 -574
- Misses 728 1517 +789
+ Partials 1474 1062 -412 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Made the stemmer set-up code identical across SuggestionDataBase::initXapianDb() and XapianDbMetadata::XapianDbMetadata().
This is a quick fix to zimcheck's output being polluted by libzim's own unsolicited messages. Writer code keeps printing to stdout but it's less of a concern
kelson42
force-pushed
the
prevention_of_stdout_pollution
branch
from
July 11, 2026 13:41
ede29ad to
ed3ccbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes openzim/zim-tools#507
Depends on openzim/zim-testing-suite#16 (so that unit-tests don't fail)