Rename to .zim file, after the checksum append#1108
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 56.39% 56.39%
=======================================
Files 100 100
Lines 5050 5050
Branches 2241 2241
=======================================
Hits 2848 2848
Misses 728 728
Partials 1474 1474 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the ZIM creation finalization flow in Creator::finishZimCreation() so the checksum is appended before the temporary output file is renamed to the final .zim filename, aiming to avoid exposing an invalid “final” file name during checksum computation (Fixes #1107).
Changes:
- Move checksum appending to occur before renaming the temporary file to the final output name.
- Ensure the final output name is only used once the checksum has been written.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+506
to
511
| INFO("Adding checksum..."); | ||
| addChecksum(data->tmpFileName); | ||
|
|
||
| TINFO("rename tmpfile to final one."); | ||
| DEFAULTFS::rename(data->tmpFileName, data->zimName); | ||
| data->tmpFileName.clear(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1106
Superseeds #1107