improve Combinator builder selection UI#1216
Open
ziaddevv wants to merge 1 commit into
Open
Conversation
ziaddevv
force-pushed
the
combinator-selection-ui
branch
from
July 17, 2026 21:26
87958c4 to
e197963
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 92.61% 92.71% +0.09%
==========================================
Files 78 78
Lines 4969 4994 +25
==========================================
+ Hits 4602 4630 +28
+ Misses 367 364 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
audiodude
requested changes
Jul 19, 2026
audiodude
left a comment
audiodude
left a comment
Member
There was a problem hiding this comment.
Just one question, looks good otherwise. Good idea to bundle these fixes together.
Comment on lines
383
to
+387
| availableIncludeBuilders: function (project) { | ||
| return this.availableBuildersFor(project, this.includeBuilders); | ||
| return this.availableBuildersFor(project, this.selectedBuilderIds()); | ||
| }, | ||
| availableExcludeBuilders: function (project) { | ||
| return this.availableBuildersFor(project, this.excludeBuilders); | ||
| return this.availableBuildersFor(project, this.selectedBuilderIds()); |
Member
There was a problem hiding this comment.
These functionas are now identical, which indicates a design flaw of some sort. Or possibly a logic error? What code is calling these that expects separate *IncludeBuilders and *ExcludeBuilders, but both lists are the same? I would refactor that code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves some error messages
+
fixes #1206 #1207 #1208