Repository navigation
[GR-79891] WordCast issue in AMD64MemoryMaskingAddressUsagePolicy. - #14529
Merged
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem to be solved
With AMD64 MemoryMaskingAndFencing enabled, the address-lowering phase treats WordCastNode as an address pass-through and examines its downstream users.
For a graph such as:
the downstream user correctly causes the address to require masking. However, the immediate WordCastNode was not classified as a node that may receive a masked address. The fail-closed validation therefore aborted compilation with:
VOS-JIT in MLE encounters this pattern through runtime/GC barrier paths, causing failed runtime compilations and resulting performance regressions.
Champion Reviewer
@"raphael.m.mosaner@oracle.com"