fix(BytecodeNode): Return -1 from BytecodeNode BCI lookups when the BCI slot is unset - #14536
Open
The-Alchemist wants to merge 1 commit into
Open
The-Alchemist wants to merge 1 commit into
The-Alchemist wants to merge 1 commit into
Conversation
With storeBytecodeIndexInFrame, the BCI slot is written lazily. A frame read before the first write still has the slot marked Illegal, so BytecodeNode.getBytecodeIndex(Frame) and findBytecodeIndex threw FrameSlotTypeException. They now apply the same Illegal check as the root node's findBytecodeIndex and return -1. Signed-off-by: The-Alchemist <kap4020@gmail.com>
oracle-contributor-agreement
Bot
added
the
OCA Verified
The-Alchemist
marked this pull request as ready for review
September 26, 2026 22:03
The-Alchemist
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storeBytecodeIndexInFrame = true, the bytecode index is written to the frame lazily, only before operations that need it. A frame read before the first write (for example, one materialized by the first operation in a root) still has the BCI slot markedIllegal.BytecodeNode.getBytecodeIndex(Frame)and bothfindBytecodeIndex(...)overrides read the slot unconditionally, so they threwFrameSlotTypeExceptioninstead of reporting an unknown location.findBytecodeIndex(Node, Frame)already guarded against this and returned-1. TheBytecodeNodevariants now share that piece of code through a single helperReadBytecodeLocationTest#testReadBeforeStore, which reads the location through all three entry points before any BCI store.Feedback welcome!