-
Notifications
You must be signed in to change notification settings - Fork 437
docs: added migration guide redirect (and fixed other link issues). Fixed welcome page issue. #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ece317 to
39e9cbb
Compare
39e9cbb to
ea4b2a5
Compare
docs/kratos/guides/zero-trust-iap-proxy-identity-access-proxy.mdx
Outdated
Show resolved
Hide resolved
wassimoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small things
docs/kratos/self-service/flows/verify-email-account-activation.mdx
Outdated
Show resolved
Hide resolved
docs/kratos/self-service/flows/verify-email-account-activation.mdx
Outdated
Show resolved
Hide resolved
docs/kratos/self-service/flows/verify-email-account-activation.mdx
Outdated
Show resolved
Hide resolved
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks the link changes look good to me.
but I don't understand why the src/pages/index.tsx is needed? we already redirect from / to /welcome on prod - and I don't want to approve without understanding why it needs to be there
I would prefer if this extra dummy page is reverted and we just get this merged - if we need it you can still add it in a separate PR.
Also "TLS code samples removed" doesn't seem to be included here? but I think those should also be done in a separate PR.
The more granular the changes are in a PR the easier they are to review, the faster we can merge them and move on
|
|
removed src/pages/index.tsx |
Changes
vercel.jsonto route/docs/migrate-to-oryto/docs/migrate-to-ory/migrateChecklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.