Skip to content

Conversation

@unatasha8
Copy link
Contributor

@unatasha8 unatasha8 commented Dec 10, 2025

Changes

  • Migration guide redirect: Added redirect rule in vercel.json to route /docs/migrate-to-ory to /docs/migrate-to-ory/migrate
  • Broken links fixes: Updated documentation links across multiple guides (CLI, Hydra, Kratos, Keto, Polis) to remove outdated broken anchors and use correct paths
  • TLS code samples removed: Removed "Fake TLS termination" and "Skip TLS verification" code examples from the Go self-hosted Hydra documentation (docs/hydra/self-hosted/05_go.mdx) as TLS is no longer supported

Checklist

  • [ X] I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • [ X] I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@unatasha8 unatasha8 requested a review from wassimoo December 10, 2025 17:08
@unatasha8 unatasha8 requested a review from vinckr as a code owner December 10, 2025 17:08
@unatasha8 unatasha8 added the area/docs This issue affects Ory's documentation. label Dec 10, 2025
@unatasha8 unatasha8 changed the title Added migration guide redirect (and fixed other link issues). Fixed welcome page issue. docs: Added migration guide redirect (and fixed other link issues). Fixed welcome page issue. Dec 10, 2025
@vinckr vinckr force-pushed the una-fixRedirect-LocalBuild branch 2 times, most recently from 0ece317 to 39e9cbb Compare December 15, 2025 15:53
@unatasha8 unatasha8 requested a review from aeneasr December 16, 2025 11:26
Copy link
Contributor

@wassimoo wassimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wassimoo wassimoo changed the title docs: Added migration guide redirect (and fixed other link issues). Fixed welcome page issue. docs: added migration guide redirect (and fixed other link issues). Fixed welcome page issue. Dec 16, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks the link changes look good to me.
but I don't understand why the src/pages/index.tsx is needed? we already redirect from / to /welcome on prod - and I don't want to approve without understanding why it needs to be there

I would prefer if this extra dummy page is reverted and we just get this merged - if we need it you can still add it in a separate PR.

Also "TLS code samples removed" doesn't seem to be included here? but I think those should also be done in a separate PR.

The more granular the changes are in a PR the easier they are to review, the faster we can merge them and move on

@unatasha8
Copy link
Contributor Author

unatasha8 commented Dec 16, 2025

thanks the link changes look good to me. but I don't understand why the src/pages/index.tsx is needed? we already redirect from / to /welcome on prod - and I don't want to approve without understanding why it needs to be there

I would prefer if this extra dummy page is reverted and we just get this merged - if we need it you can still add it in a separate PR.
****From 'master' branch, can you test building the help in your local environment using 'npm run build' It does not generate a doc site with the Welcome page. It used to... I added src/pages/index.tsx to fix this.

Also "TLS code samples removed" doesn't seem to be included here? but I think those should also be done in a separate PR.
****The samples were removed from 'docs/hydra/self-hosted/05_go.mdx' which is included in this PR.

The more granular the changes are in a PR the easier they are to review, the faster we can merge them and move on
***These changes are all related to broken links (even removing the TLS code samples).

@unatasha8
Copy link
Contributor Author

removed src/pages/index.tsx

@unatasha8 unatasha8 merged commit f537d64 into master Dec 16, 2025
9 checks passed
@unatasha8 unatasha8 deleted the una-fixRedirect-LocalBuild branch December 16, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs This issue affects Ory's documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants