Add OCI to test suite runner - #579
Open
sshmulev wants to merge 2 commits into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- As more cloud providers are added, consider refactoring the
get_default_test_suite_pathsconditional chain into a mapping/dictionary ofcloud_provider -> test suite pathto make it easier to extend and maintain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- As more cloud providers are added, consider refactoring the `get_default_test_suite_paths` conditional chain into a mapping/dictionary of `cloud_provider -> test suite path` to make it easier to extend and maintain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sshmulev
force-pushed
the
add_oci_to_suit_runner
branch
from
July 23, 2026 11:19
636dce0 to
1abe961
Compare
sshmulev
enabled auto-merge (rebase)
July 23, 2026 11:20
sshmulev
force-pushed
the
add_oci_to_suit_runner
branch
from
July 23, 2026 11:44
1abe961 to
049b6d9
Compare
OCI images always have a separate /boot partition, so test_boot_mount_presence should not assert its absence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.