Skip to content

fix(oci): update sshd, driver and /boot tests - #585

Open
psiayn wants to merge 3 commits into
osbuild:mainfrom
psiayn:oci_failures_fix
Open

fix(oci): update sshd, driver and /boot tests#585
psiayn wants to merge 3 commits into
osbuild:mainfrom
psiayn:oci_failures_fix

Conversation

@psiayn

@psiayn psiayn commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Fix failing tests for OCI:-

  • update sshd to check for uncommented PsswordAuthentication yes by updating regex
  • update network driver to check the correct uevent file
  • add oci as a case for /boot drive as it's lvm only

update sshd to check for uncommented PasswordAuthentication yes
update network driver to check the correct path
add oci as a case for /boot drive as it's lvm only

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the test_sshd_config assertion, consider making the regex more robust so it also catches lines with leading whitespace and extra spacing (e.g. using a raw string like r'^\s*PasswordAuthentication\s+yes\b') to ensure all uncommented PasswordAuthentication yes variants are rejected.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the `test_sshd_config` assertion, consider making the regex more robust so it also catches lines with leading whitespace and extra spacing (e.g. using a raw string like `r'^\s*PasswordAuthentication\s+yes\b'`) to ensure all uncommented `PasswordAuthentication yes` variants are rejected.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sshmulev sshmulev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, have you to tested this with the new changes before we merged this?

@psiayn

psiayn commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry not yet, let me do a trial run. I ran pytest test/ and flake8.

@sshmulev sshmulev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants