Open
Conversation
added 6 commits
January 26, 2018 10:26
- Added a request class for firebase - Fixed specs for the above changes
- Defined Firebase::Database class to Replace CLient later - Rubocop fixes
…mbol keys What : Reverting these
EdwinRozario
force-pushed
the
ed/ruby-updates
branch
from
06fe623 to
c17bd5a
Compare
Collaborator
|
Hi Edwin, sorry about the delay. I think that my problem with this PR is that it does too much for the benefit provided. If you're interested in adding support for additional Firebase products, I'd rather look at specific PRs for that rather than a general overhaul of the entire gem. For instance, changes to the new hash syntax will break old Ruby compatibility. It's fine to do that, but we're not getting much benefit out of doing that right now. |
Author
|
@vincentwoo The reason i have separated classes is to make future addition of other Firebase services easier. |
Collaborator
|
I know, but unless we have an active plan to do that work, we are basically asking all our downstream users to refactor their code for no gain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.