Skip to content

Fully implement DistributionMeasure and add var transforms - #6

Merged
oschulz merged 90 commits into
mainfrom
transforms
Jun 21, 2022
Merged

Fully implement DistributionMeasure and add var transforms#6
oschulz merged 90 commits into
mainfrom
transforms

Conversation

@oschulz

@oschulz oschulz commented Jun 18, 2022

Copy link
Copy Markdown
Owner

No description provided.

@oschulz oschulz changed the title [WIP] Fully implement DistributionMeasure and add var transforms Fully implement DistributionMeasure and add var transforms Jun 18, 2022
@oschulz

oschulz commented Jun 18, 2022

Copy link
Copy Markdown
Owner Author

Passes tests locally, will need a new release of MeasureBase to run CI.

@codecov

codecov Bot commented Jun 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6 (319f97d) into main (9b59ee1) will increase coverage by 76.79%.
The diff coverage is 79.42%.

@@            Coverage Diff             @@
##            main       #6       +/-   ##
==========================================
+ Coverage   0.00%   76.79%   +76.79%     
==========================================
  Files          2       14       +12     
  Lines         41      362      +321     
==========================================
+ Hits           0      278      +278     
- Misses        41       84       +43     
Impacted Files Coverage Δ
src/product.jl 0.00% <0.00%> (ø)
src/distribution_measure.jl 33.33% <42.10%> (+33.33%) ⬆️
src/stdnormal_measure.jl 44.44% <44.44%> (ø)
src/utils.jl 44.44% <44.44%> (+44.44%) ⬆️
src/univariate.jl 70.31% <70.31%> (ø)
src/reshaped.jl 75.00% <75.00%> (ø)
src/standard_dist.jl 80.00% <80.00%> (ø)
src/measure_interface.jl 84.61% <84.61%> (ø)
src/standard_normal.jl 85.71% <85.71%> (ø)
src/standard_uniform.jl 97.36% <97.36%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b59ee1...319f97d. Read the comment docs.

@oschulz
oschulz marked this pull request as ready for review June 19, 2022 23:34
Comment thread src/measure_interface.jl Outdated
Comment thread src/utils.jl Outdated
Comment thread src/univariate.jl Outdated
Comment thread src/measure_interface.jl Outdated
Comment thread src/standard_dist.jl Outdated
Comment thread src/univariate.jl Outdated
@oschulz

oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Owner Author

We should wait for JuliaMath/MeasureBase.jl#63 before merging and tagging.

@oschulz
oschulz merged commit 03c5f17 into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants