Add CloudFormation express mode support - #458
Merged
Merged
Conversation
|
works like a charm, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudFormation express mode completes stack operations as soon as resource configuration is applied, which makes iterative deployments and removals considerably faster for development stages. This adds
provider.deploymentMode: express, which makes osls passDeploymentConfigon the create, update and change set calls used bydeployandrollback, and on the delete call used byremove. The existingprovider.disableRollbacksetting keeps its meaning: osls sends it insideDeploymentConfig, so a failed express deployment still rolls back unless the user has opted out, unlike the raw CloudFormation default. Because CloudFormation rejectsOnFailurein express mode, a failed stack creation with the direct method is left inROLLBACK_COMPLETErather than deleted, which the documentation now explains along with the constraints CloudFormation applies to stacks that failed with rollback disabled and how to recover from them. After an express operation osls prints a short notice that resources may still be stabilizing. The behaviour was verified against a live account for both deployment methods, custom deployment buckets, rollback, removal and the failure and recovery paths. Builds on the SDK floors raised in #457 and closes #456.