Repository navigation
Go 1.26, SAST and hostile-input hardening, go-modbus v1.11.1 (v3.5.0) - #25
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
- Device and file strings are escaped in text/table output and errors. - Outputs refuse symlinks, are created 0600, and may not name the command's own input (it was truncated before being read). - Deep scan stayed inside --end at 65535; replay refuses NaN/Inf/huge speeds and oversized reads; discover refuses huge subnets at once; JSON inputs capped at 16 MiB; healthcheck has timeouts and validates -http. - gosec 64 -> 0 with no triage: range-checked conversions (internal/conv), internal/fsutil, x/sys/unix pty ioctls instead of unsafe. - Hostile tests and six fuzz targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
boeboe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares v3.5.0 (RELEASE.md has the details).
go fix, shared workflows v3.3.1, go-modbus v1.11.1.internal/fsutilfor files, x/sys/unix pty ioctls instead of unsafe, validated healthcheck URL).--outputnaming the input truncated it before reading; deep scan left the range at 65535; replay took NaN/Inf speeds and answered oversized reads with a wrapped byte count; discover enumerated0.0.0.0/0before refusing it; unbounded JSON inputs; healthcheck without timeouts.make check,make e2egreen locally; Linux race run in Docker.🤖 Generated with Claude Code