add a shared namespace#56
Open
RobinQu wants to merge 3 commits into
Open
Conversation
Owner
|
What's the use case behind this? In principle, I have no objection, but I'd like to understand what you're trying to do. Also, before this gets merged, it'll need tests and documentation. |
binki
reviewed
Sep 29, 2016
| reset : reset, | ||
| getSharedNamespace: function () { | ||
| if (!process.sharedNamespace) { | ||
| process.sharedNamespace = create('shared_' + Date.now() + '_' + Math.random()); |
There was a problem hiding this comment.
Instead of generating a random name and leaving things to chance, why not consider doing it right and implementing anonymous namespaces as I requested in #52?
|
Instead of some “shared namespace” why not just use an agreed-upon namespace name? I agree with @othiym23, the goal of this PR is unclear and the only use cases I can guess at are nonsensical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.