AO3-7293 Add unactioned and unwrangleable status filters to tag search#5588
Open
marcus8448 wants to merge 4 commits intootwcode:masterfrom
Open
AO3-7293 Add unactioned and unwrangleable status filters to tag search#5588marcus8448 wants to merge 4 commits intootwcode:masterfrom
marcus8448 wants to merge 4 commits intootwcode:masterfrom
Conversation
It doesn't make sense to search for both separately (e.g. can't be canon + unwrangleable), and status=unwrangleable should cover it. It appears to be unused (and was not exposed to tag search).
Bilka2
reviewed
Feb 23, 2026
| end | ||
|
|
||
| def unwrangleable_filter | ||
| term_filter(:unwrangleable, bool_value(options[:unwrangleable])) unless options[:unwrangleable].nil? |
Contributor
There was a problem hiding this comment.
I am surprised this removal doesn't cause test failures, isn't this option used in tag_counts_per_category, unwrangled_query, TagWranglingsController#index and even the tag_query spec?
Member
Author
There was a problem hiding this comment.
Welp, I searched for :unwrangleable and not unwrangleable:... probably should've just searched all TagQuerys.
Tests pass because there's a typo:
I'll restore the filter and fix the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7293
Purpose
Adds two more wrangling status options to tag search: "Unwrangleable" and "Non-canonical and non-synonymous and not marked unwrangleable" (which are tags that have not been actioned in some way).
Credit
marcus8448 (he/him)