add new test and update#376
Conversation
Update .travis.yml Update dependencies and build configuration for nginx Update test_new.yml Update test_new.yml Update test_new.yml Update test.yml Update test_new.yml Update test_new.yml
There was a problem hiding this comment.
Pull request overview
This PR expands CI coverage for the ModSecurity-nginx connector by updating the existing GitHub Actions workflow to handle the current ModSecurity submodule layout and by adding a new multi-version test workflow for newer Nginx releases. It also refreshes the legacy Travis setup to build against a newer Nginx release from the Git repository instead of release tarballs.
Changes:
- Updated existing CI checkout steps to fetch ModSecurity submodules recursively so nested dependencies like mbedTLS are available.
- Added a new
test_new.ymlworkflow that resolves1.30.x/1.29.x/1.28.xto concrete Nginx release refs and runs Linux and Windows builds/tests against them. - Adjusted
.travis.ymlto test a newer Nginx version and switch Nginx/nginx-tests source retrieval from tarballs to Git clones.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.travis.yml |
Refreshes Travis CI inputs and switches Nginx/nginx-tests fetching to Git clones. |
.github/workflows/test_new.yml |
Adds a new multi-version GitHub Actions workflow for Linux and Windows CI. |
.github/workflows/test.yml |
Updates existing ModSecurity checkout steps to use recursive submodules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated Nginx installation and configuration steps in the workflow. Removed deprecated version resolution logic for Nginx.
|
|
Thank you, @Easton97-Jens! |
what
test.ymlto align with the latest ModSecurity setuptest_new.ymltest_new.ymltests multiple Nginx versions (1.30.x,1.29.x,1.28.x)x)why
references