[WIP] email share notification should be done in the background#32125
Closed
[WIP] email share notification should be done in the background#32125
Conversation
sharidas
force-pushed
the
background-share-notification
branch
from
d265547 to
2c998b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #32125 +/- ##
============================================
- Coverage 63.96% 63.96% -0.01%
- Complexity 18598 18600 +2
============================================
Files 1172 1172
Lines 69833 69837 +4
Branches 1267 1267
============================================
+ Hits 44669 44670 +1
- Misses 24795 24798 +3
Partials 369 369
Continue to review full report at Codecov.
|
sharidas
force-pushed
the
background-share-notification
branch
from
2c998b5 to
9b02008
Compare
Contributor
Author
|
The acceptance test has failed due to the change. Looking for the fix. |
sharidas
force-pushed
the
background-share-notification
branch
from
9b02008 to
a5b37ba
Compare
sharidas
changed the title
The share notification through email should be done in the background. This change helps to split the notification of users and email as separate tasks. Its always better to have email notification as background job. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
background-share-notification
branch
from
a5b37ba to
1c10ddc
Compare
Member
|
As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase. This PR targetted ownCloud 11 which is postponed to a far distant future. Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days. Thanks a lot for your patience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The share notification should be done as background
process. This would help for groups with large users
to send notifications and emails.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: