test: process APP_NAME when deciding what apps to disable#41540
Merged
phil-davis merged 1 commit intomasterfrom Apr 24, 2026
Merged
test: process APP_NAME when deciding what apps to disable#41540phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
When running acceptance tests, we disable the firstrunwizard and notifications app by default. These apps are often provided in a bundled ownCloud core tarball. But they can get in the way of webUI tests, because: - the firstrunwizard might display itself at the very start of testing - notifications can appear at the top of the webUI, and might obscure things that are being tested. But if we are actually testing one of these apps, then we don't want to disable the app. The logic in acceptance ytetst run.sh is enhanced to avoid disabling the app when it is the app-under-test.
Contributor
Author
|
Tried in PRs owncloud/notifications#394 It works, avoiding “accidentally” disabling the app-under-test when the acceptance tests are starting. |
saw-jan
approved these changes
Apr 24, 2026
DeepDiver1975
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running acceptance tests, we disable the firstrunwizard and notifications app by default. These apps are often provided in a bundled ownCloud core tarball. But they can get in the way of webUI tests, because:
But if we are actually testing one of these apps, then we don't want to disable the app.
The logic in acceptance test run.sh is enhanced to avoid disabling the app when it is the app-under-test.