test: delete any existing app code before copying app-under-test#56
Merged
phil-davis merged 1 commit intomainfrom Apr 24, 2026
Merged
test: delete any existing app code before copying app-under-test#56phil-davis merged 1 commit intomainfrom
phil-davis merged 1 commit intomainfrom
Conversation
The owncloud core tarball often has some extra apps bundled in it. For example, notifications or firstrunwizard. But when running acceptance tests for one of these "bundled" apps, we want to ensure that we are running the app code from the PR branch. So, before copying the app code to the server, first delete any existing app code. "rm -rf" has been used so that it always deletes the whole directory tree, and does not complain if the directory does not exist. That allows us to always do this "rm" in the setup for every app.
Contributor
Author
|
Tested with owncloud/firstrunwizard#191 and the CI passes there. Also helps for notifications app owncloud/notifications#394 |
DeepDiver1975
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owncloud core tarball often has some extra apps bundled in it. For example, notifications or firstrunwizard.
But when running acceptance tests for one of these "bundled" apps, we want to ensure that we are running the app code from the PR branch.
So, before copying the app code to the server, first delete any existing app code. "rm -rf" has been used so that it always deletes the whole directory tree, and does not complain if the directory does not exist. That allows us to always do this "rm" in the setup for every app.