fix: [OCISDEV-554] duped call for public share access with p/w

[existentialcoder]

Description

• Every time a new shared link is accessed with a password, two redundant calls are made to list the files
• The first one is a watcher listener and a second is to verify password
• This PR makes sure the watcher triggers the network call only during password verification.

Related Issue

• Fixes [OCISDEV-554] Password protected share gets authenticated twice #13363

Motivation and Context

Removed a duplicated call for the files-list when accessing a password protected shared link

How Has This Been Tested?

Unit and manual tests

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests
• Documentation
• Maintenance (e.g. dependency updates or tooling)

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[CLAassistant]

All committers have signed the CLA.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[LukasHirt]

Could you please add unit tests to verify that the change prevent the second call?

[existentialcoder]

Could you please add unit tests to verify that the change prevent the second call?

Trying to get an idea here. @LukasHirt

The authService is actually mocked in the test and therefore the watcher won't be triggered.

Can the authService test file instead include this test since the changes are added there? TIA

Btw a screenshot from manual test

[LukasHirt]

I took a closer look now and see that the index file is anyway not yet covered with unit tests at all. There's quite a lot happening in that file so adding the tests would take a bit longer than I originally thought. If you have an idea for a simple tests somewhere else that would cover your changes, feel free to add them. Otherwise I would be fine with just doing manual testing and leaving unit tests for now.

[existentialcoder]

I took a closer look now and see that the index file is anyway not yet covered with unit tests at all. There's quite a lot happening in that file so adding the tests would take a bit longer than I originally thought. If you have an idea for a simple tests somewhere else that would cover your changes, feel free to add them. Otherwise I would be fine with just doing manual testing and leaving unit tests for now.

Yeah. I will check and add it in the authService test. Also getting your opinion on whether these duplicate calls are to be removed post successful password submission. These are after routing to the public share directory

[LukasHirt]

Yes, if there are more duplicate calls we should handle those as well. If the fix for it is simple, I would include it in this PR. If it's a bit more complex, I would suggest separate PR.

[existentialcoder]

Yes, if there are more duplicate calls we should handle those as well. If the fix for it is simple, I would include it in this PR. If it's a bit more complex, I would suggest separate PR.

Yes can be taken separately. As you mentioned this needs a separate test file for index.ts. Should we take this PR without the test?