Repository navigation
fix(gui): allow partial selection of message text #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
689b6ee
feat(gui): enable partial selection of message text
jlucaso1 46f05eb
fix(gui): resolve selection build errors
jlucaso1 a7f1887
fix(gui): retain link presses across repaint
jlucaso1 a1463df
fix(gui): clear selection only for identity changes
jlucaso1 8d9619f
fix(gui): keep message selection tied to virtualized identity
jlucaso1 a793294
fix(gui): pass selection identity to all rich text paths
jlucaso1 e9210d6
test(gui): focus the text selection copy shortcut
jlucaso1 fd5d42d
fix(gui): clear stale selections with timeline visibility
jlucaso1 7b23149
fix(gui): clear selection when settings hides chat
jlucaso1 2417c74
style(gui): clarify active selection lookup
jlucaso1 ded2346
fix(gui): handle bidi selection and pointer slop
jlucaso1 5d1ba36
fix(gui): clear transient selection on link click
jlucaso1 dec52c3
fix(gui): derive highlights from visual glyph runs
jlucaso1 dd3f45a
fix(gui): bound wrapped bidi selection glyphs
jlucaso1 87e7291
fix(gui): import pixel half trait
jlucaso1 373592e
fix(gui): retain virtualized selection and refine hits
jlucaso1 a36bd39
fix(gui): remove unnecessary test context mut
jlucaso1 3174a19
test(gui): cover link end hit testing
jlucaso1 6a664d6
fix(gui): preserve retained text and shaped glyph bounds
jlucaso1 3c834c2
fix(gui): retain virtual selection order efficiently
jlucaso1 15c6809
fix(gui): preserve shaped caret and receipt selections
jlucaso1 fa5cd84
fix(gui): address shaped caret clippy feedback
jlucaso1 32ae2db
fix(gui): keep trailing carets within wrapped segments
jlucaso1 275f625
fix(gui): measure wrapped clusters from shaped glyph positions
jlucaso1 c25a0e0
fix(gui): correct shaped pixel delta
jlucaso1 37ed89f
fix(gui): preserve positioned glyph cluster extents
jlucaso1 6e47e95
fix(gui): preserve RTL trailing cluster advances
jlucaso1 10aa0de
fix(gui): close selection lifecycle gaps
jlucaso1 1615266
test(gui): cover retained selection lifecycle
jlucaso1 ba04aed
test(gui): import rich text builder helpers
jlucaso1 6b95703
test(gui): scope selection checks to visual context
jlucaso1 ee3b154
test(gui): draw before asserting text selection
jlucaso1 0ae39ec
test(gui): satisfy clippy in selection fixture
jlucaso1 816f9a2
fix(gui): retain selected virtualized participants
jlucaso1 4bb8558
fix(gui): use an empty layout child list
jlucaso1 7a466e6
style(gui): simplify selection keepalive flow
jlucaso1 fa82463
fix(gui): cache copied selection for virtualized rows
jlucaso1 80bef13
fix(gui): scale dormant selection geometry
jlucaso1 a792886
fix(gui): preserve selection geometry while virtualized
jlucaso1 f725990
style(gui): avoid cloning selection bounds
jlucaso1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.