Repository navigation
Add CI step to build and push Ubuntu 26.04 docker image - #693
Open
jafingerhut wants to merge 1 commit into
Open
jafingerhut wants to merge 1 commit into
jafingerhut wants to merge 1 commit into
Conversation
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
fruffy
approved these changes
Oct 30, 2026
fruffy
requested changes
Oct 30, 2026
| tags: p4lang/pi:${{ steps.get-tag.outputs.tag }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
| - name: Build and push Dockerfile.ubuntu-26.04 image if needed |
Contributor
There was a problem hiding this comment.
Not quite sure this makes sense? The image is pushed without being tested
Contributor
Author
There was a problem hiding this comment.
The docker image build that exists today is also pushed without being tested, so it isn't quite backsliding :-)
I can look into what kinds of at least smoke test might be run for the existing docker build and use the same thing for this new one, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.