Repository navigation
Conversation
Scope full Bazel caches to runner image, architecture, and Bazel version so Ubuntu runner upgrades cannot reuse a stale detected C/C++ toolchain. Use per-run main/PR keys with scoped restore fallbacks, and run daily cache maintenance through the shared p4lang/.github action. Fixes the cache-related Bazel failure in #689. Shared action: p4lang/.github#22. Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
This was referenced Nov 2, 2026
Signed-off-by: fruffy <fruffy@nyu.edu>
Require the first BoringSSL snapshot after upstream moved its crypto implementation to C++. Its const-correct memchr overloads compile with glibc 2.43, unlike the C wrapper selected by gRPC 1.76.0. Combine this dependency update from #699 with the cache isolation in #694 so that Ubuntu 26.04 CI can build with a compatible local toolchain. Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
commented
Nov 14, 2026
|
|
||
| bazel_dep(name = "bazel_skylib", version = "1.9.0") | ||
| bazel_dep(name = "boost.container_hash", version = "1.90.0.bcr.1") | ||
| bazel_dep(name = "boringssl", version = "0.20241209.0", repo_name = None) |
Contributor
Author
There was a problem hiding this comment.
@jafingerhut This fixes the Ubuntu 24.04 compilation issues.
Signed-off-by: fruffy <fruffy@nyu.edu>
This was referenced Nov 15, 2026
Contributor
|
I can approve if you wish, but it would be great if @chreekat could take a look at it, both for his knowledge of changes going in, and preferably also for his more knowledgeable review than I can give. FYI using a similar boringssl version specification in the p4runtime repository does not fix the build issue with ubuntu-26.04 in that repository. Not sure why yet. It is not urgent by any means. p4lang/p4runtime#650 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three things in the Bazel build:
With these fixes, we can undo the temporary Ubuntu 24.04 pin from #698 and use
ubuntu-latestagain.