Repository navigation
Conversation
Contributor
Author
|
The bazel failure is getting fixed in #1475 |
flush_trace created trace_<id>.txtpb empty and then wrote it, which raced any reader of the trace directory. An empty file parses as an empty PacketTrace, so test_packet_trace's poll could accept it as the case's one trace and print it without events. packet_trace_parser_error failed this way on Ubuntu 22.04 and 26.04 aarch64 builds. Signed-off-by: Bryan Richter <b@chreekat.net>
chreekat
force-pushed
the
b/atomic-packet-trace-files
branch
from
October 30, 2026 07:39
2156483 to
b878cbe
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flush_trace created trace_.txtpb empty and then wrote it. This created a condition where test_packet_trace's poll could see an empty file and accept it as the case's one trace and print it without events. packet_trace_parser_error failed this way on Ubuntu 22.04 and 26.04 aarch64 builds.