Skip to content

tests: Publish packet trace files atomically - #1474

Open
chreekat wants to merge 1 commit into
b/bazel-cache-per-toolchainfrom
b/atomic-packet-trace-files
Open

chreekat wants to merge 1 commit into
b/bazel-cache-per-toolchainfrom
b/atomic-packet-trace-files

Conversation

@chreekat

Copy link
Copy Markdown
Contributor

flush_trace created trace_.txtpb empty and then wrote it. This created a condition where test_packet_trace's poll could see an empty file and accept it as the case's one trace and print it without events. packet_trace_parser_error failed this way on Ubuntu 22.04 and 26.04 aarch64 builds.

@chreekat

Copy link
Copy Markdown
Contributor Author

The bazel failure is getting fixed in #1475

flush_trace created trace_<id>.txtpb empty and then wrote it, which raced
any reader of the trace directory. An empty file parses as an empty
PacketTrace, so test_packet_trace's poll could accept it as the case's one
trace and print it without events. packet_trace_parser_error failed this
way on Ubuntu 22.04 and 26.04 aarch64 builds.

Signed-off-by: Bryan Richter <b@chreekat.net>
@chreekat
chreekat force-pushed the b/atomic-packet-trace-files branch from 2156483 to b878cbe Compare October 30, 2026 07:39
@chreekat
chreekat changed the base branch from main to b/bazel-cache-per-toolchain October 30, 2026 07:39
@chreekat
chreekat added this pull request to stack #1476 October 30, 2026 08:53
@fruffy

fruffy commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@matthewtlam @c8ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants