Repository navigation
Add use of reusable workflow in p4lang/.github repo for license check - #1482
Conversation
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
| # SPDX-FileCopyrightText: 2026 The P4 Language Consortium | ||
| # |
There was a problem hiding this comment.
Was there any particular reason you chose to create a new workflow file? If it were me, I probably would have just modified the existing job in the existing workflow.
There was a problem hiding this comment.
No big reason, no. Having a separate workflow file for it meant that I could copy that same file to all of the p4lang repos with no modification, so slightly quicker when creating all the PRs across ~10 repositories. It makes the use of the reusable workflow pretty much identical across all of those, versus slightly different in all of them.
There was a problem hiding this comment.
Well, to be honest, that makes sense.
I had kind of developed a personal strategy of using workflows to organize "when the jobs run": one workflow per set of related triggers. By that metric, having a new workflow that also runs on PRs is duplication.
But to be honest, it's not an airtight strategy. I feel like we're stuck between a rock and a hard place with GitHub's design.
No description provided.