Skip to content

Add use of reusable workflow in p4lang/.github repo for license check - #1482

Merged
jafingerhut merged 1 commit into
p4lang:mainfrom
jafingerhut:use-reusable-workflow-for-license-check
Nov 8, 2026
Merged

jafingerhut merged 1 commit into
p4lang:mainfrom
jafingerhut:use-reusable-workflow-for-license-check

Conversation

@jafingerhut

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
@jafingerhut
jafingerhut requested a review from chreekat November 3, 2026 04:11
Comment on lines +1 to +2
# SPDX-FileCopyrightText: 2026 The P4 Language Consortium
#

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any particular reason you chose to create a new workflow file? If it were me, I probably would have just modified the existing job in the existing workflow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big reason, no. Having a separate workflow file for it meant that I could copy that same file to all of the p4lang repos with no modification, so slightly quicker when creating all the PRs across ~10 repositories. It makes the use of the reusable workflow pretty much identical across all of those, versus slightly different in all of them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, to be honest, that makes sense.

I had kind of developed a personal strategy of using workflows to organize "when the jobs run": one workflow per set of related triggers. By that metric, having a new workflow that also runs on PRs is duplication.

But to be honest, it's not an airtight strategy. I feel like we're stuck between a rock and a hard place with GitHub's design.

@jafingerhut
jafingerhut merged commit 668b27d into p4lang:main Nov 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants