Repository navigation
Fix show_envvar output for a sequence or an empty envvar - #3884
Merged
Merged
Conversation
kdeldycke
force-pushed
the
envvar-sequence-error-hint
branch
from
October 6, 2026 13:50
2e07b32 to
b285c68
Compare
kdeldycke
force-pushed
the
envvar-sequence-error-hint
branch
from
October 6, 2026 13:54
b285c68 to
c53d373
Compare
Rowlando13
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some awkward rendering in the
Error: Invalid value for '--units' (env var: xxxxx)error message's hint for special cases of environment variables:envvar=Noneenvvar=""(env var: '')envvar=[](env var: '[]')envvar=["WEATHER_UNITS", "UNITS"](env var: '['WEATHER_UNITS', 'UNITS']')(env var: 'WEATHER_UNITS', 'UNITS')Also fixes the rendering of help screen:
envvar=Noneenvvar=""[env var: ]envvar=[][env var: ]