Skip to content

Fix show_envvar output for a sequence or an empty envvar - #3884

Merged
Rowlando13 merged 1 commit into
pallets:stablefrom
kdeldycke:envvar-sequence-error-hint
Oct 6, 2026
Merged

Rowlando13 merged 1 commit into
pallets:stablefrom
kdeldycke:envvar-sequence-error-hint

Conversation

@kdeldycke

@kdeldycke kdeldycke commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

This PR fixes some awkward rendering in the Error: Invalid value for '--units' (env var: xxxxx) error message's hint for special cases of environment variables:

Parameter value Hint before Hint after
envvar=None Nothing Nothing
envvar="" (env var: '') Nothing
envvar=[] (env var: '[]') Nothing
envvar=["WEATHER_UNITS", "UNITS"] (env var: '['WEATHER_UNITS', 'UNITS']') (env var: 'WEATHER_UNITS', 'UNITS')

Also fixes the rendering of help screen:

Parameter value Help screen before Help screen after
envvar=None Nothing Nothing
envvar="" [env var: ] Nothing
envvar=[] [env var: ] Nothing

@kdeldycke kdeldycke added the help output Help text formatting, layout, and --help rendering label Oct 6, 2026
@kdeldycke kdeldycke added this to the 8.5.1 milestone Oct 6, 2026
@kdeldycke
kdeldycke force-pushed the envvar-sequence-error-hint branch from 2e07b32 to b285c68 Compare October 6, 2026 13:50
@kdeldycke
kdeldycke force-pushed the envvar-sequence-error-hint branch from b285c68 to c53d373 Compare October 6, 2026 13:54
@Rowlando13
Rowlando13 merged commit 8c73ff1 into pallets:stable Oct 6, 2026
12 checks passed
@kdeldycke
kdeldycke deleted the envvar-sequence-error-hint branch October 7, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help output Help text formatting, layout, and --help rendering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants