Conversation
Untimed serializers previously swallowed max_age via unused **kwargs, so swapping URLSafeTimedSerializer for URLSafeSerializer could silently accept expired tokens. Raise TypeError instead. Fixes pallets#429 Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
https://palletsprojects.com/contributing/llm-ai
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**kwargsfromSerializer.loadsso unexpected arguments likemax_ageraiseTypeErrorinstead of being silently ignored on non-timed serializers.URLSafeTimedSerializerforURLSafeSerializerwhile still passingmax_agewould accept expired tokens forever.Test plan
pytest tests/test_itsdangerous/— 305 passed, 4 skippedURLSafeSerializer.loads(..., max_age=-1)raisesTypeError; timed serializers still acceptmax_agefixes #429
Made with Cursor