fix(vpn): no restart when a stopped VPN fails its startup check - #3485
Merged
Merged
Conversation
A VPN run stopped during its startup check, for example with PUT /v1/vpn/status, fails the check because its context is canceled, and then restarts the VPN anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Please tick which one the following applies to your pull request:
Description
A VPN run stopped during its startup check gets restarted anyway: the check fails on the canceled context, and
onTunnelUpcallsrestartVPN. This returns early instead.Repro, with a custom wireguard provider pointing at an unreachable endpoint: during the startup check,
PUT /v1/vpn/status {"status":"stopped"}. 15s later, master reportsrunning; this PR reportsstopped.In production, a settings change at the same moment turned this into a restart storm.