Depend on bitcoin/rand for rand#261
Merged
DanGould merged 1 commit intopayjoin:masterfrom May 22, 2024
Merged
Conversation
Rand is already available in secp256k1/rand through rust-bitcoin. rand-std is also an option to use in std environments but having wide support seems more important in the near term than adding all of those feature flags to save the dependency tree for now.
jbesraa
approved these changes
May 22, 2024
Contributor
There was a problem hiding this comment.
Working, thanks!
I ran lightningdevkit/ldk-node#295 against this branch locally without the receive feature and its compiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rand is already available in secp256k1/rand transiently through rust bitcoin. rand-std is also an option to for std environments but having wide support seems more important in the near term than adding all of those feature flags.
This should fix #258 which may have been triggering in an environment where bitcoin/rand was not available.