Skip to content

chore: re-enable dev indicator #17339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulpopus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: re-enable dev indicator #17339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/next/src/withPayload/withPayload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ export const withPayload = (nextConfig = {}, options = {}) => {
/** @type {import('next').NextConfig} */
const baseConfig = {
...nextConfig,
devIndicators: nextConfig.devIndicators !== undefined ? nextConfig.devIndicators : false,
devIndicators:
nextConfig.devIndicators !== undefined
? nextConfig.devIndicators
: { position: 'bottom-right' },
env,
experimental: {
...(nextConfig.experimental || {}),
Expand Down
4 changes: 2 additions & 2 deletions packages/next/src/withPayload/withPayload.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ describe('withPayload', () => {
}
})

it('should disable devIndicators by default', () => {
it('should position devIndicators at the bottom right by default', () => {
const result = withPayload({})

expect(result.devIndicators).toBe(false)
expect(result.devIndicators).toEqual({ position: 'bottom-right' })
})

it('should use user-provided devIndicators when specified', () => {
Expand Down
Loading