fix(richtext-lexical): coerce integer upload and relationship IDs to number during HTML conversion#17357
Open
anaghroy wants to merge 1 commit into
Open
fix(richtext-lexical): coerce integer upload and relationship IDs to number during HTML conversion#17357anaghroy wants to merge 1 commit into
anaghroy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We are modifying the Lexical HTML converter (
$convertUploadElementand$relationshipElementToNode) so that when it extracts integer IDs from thedata-lexical-[type]-idHTML attribute, it correctly casts them intoNumbertypes instead of leaving them as strings.Why?
When a Payload project is configured to use integer IDs for a collection (e.g.
media), saving a Rich Text field containing Upload or Relationship nodes can fail validation. Because the Lexical DOM parser natively grabs HTML attributes as strings, it was passing a string (e.g."2") into$createNodeinstead of the integer2. This causes Payload's internal lifecycle hooks to reject the payload entirely with aValidationError.How?
Inside
conversions.tsandRelationshipNode.tsx, we added a strict type-coercion check:Screenshots
Closes #17344