fix(ui): strip row components from serializable form state#17371
Open
rasitakyol wants to merge 1 commit into
Open
fix(ui): strip row components from serializable form state#17371rasitakyol wants to merge 1 commit into
rasitakyol wants to merge 1 commit into
Conversation
rasitakyol
marked this pull request as ready for review
July 16, 2026 21:01
rasitakyol
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 16, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove row-level custom components when reducing admin form state to serializable fields.
Why?
Array and blocks rows can contain a React
RowLabelcomponent. That value may include circular references, so preview and SEO fields can fail while serializing form state even though top-level custom components are already removed.How?
Clone and sanitize each row without mutating the original form state, while preserving row metadata such as IDs, block types, and collapsed state. A focused unit test covers circular row labels, top-level non-serializable values, preserved metadata, and input immutability.
Validation:
pnpm test:unit packages/ui/src/forms/Form/reduceToSerializableFields.spec.tspnpm eslint --max-warnings=0 packages/ui/src/forms/Form/reduceToSerializableFields.tspnpm prettier --check packages/ui/src/forms/Form/reduceToSerializableFields.ts packages/ui/src/forms/Form/reduceToSerializableFields.spec.tspnpm build:uiFixes #16786