fix(drizzle): handle empty in queries on polymorphic relationships#17372
Open
rasitakyol wants to merge 1 commit into
Open
fix(drizzle): handle empty in queries on polymorphic relationships#17372rasitakyol wants to merge 1 commit into
rasitakyol wants to merge 1 commit into
Conversation
rasitakyol
marked this pull request as ready for review
July 16, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keep polymorphic relationship columns when a Drizzle
inquery receives an empty array.Why?
The type-pruning guards treated an empty array as matching every value-type check. For UUID-backed polymorphic relationships, this removed every query column, dropped the filter entirely, and returned all documents instead of none.
How?
Apply the existing numeric and UUID type-pruning rules only to non-empty arrays. A focused integration test creates a polymorphic relationship, queries it with
in: [], verifies that no documents are returned, and cleans up its records.Validation:
PAYLOAD_DATABASE=sqlite-uuid pnpm test:int relationships(58 passed, 4 skipped)PAYLOAD_DATABASE=postgres-uuid pnpm test:int relationships(58 passed, 4 skipped)pnpm build:drizzlegit diff --checkon the changed filesFixes #16195