Repository navigation
feat(discover): stacked dApp logos on folder rows [PER-2760] - #2457
Open
yasincaliskan wants to merge 2 commits into
Open
yasincaliskan wants to merge 2 commits into
yasincaliskan wants to merge 2 commits into
Conversation
Device e2e flows affected1 suite (3 scenarios, 1 p0):
Run them:
|
yasin-ce
approved these changes
Nov 16, 2026
yasin-ce
left a comment
Collaborator
There was a problem hiding this comment.
Adds a stacked dApp logo preview (up to three logos, then a +N chip) to folder rows and the All favorites row. It matches the description and is covered by unit and integration tests. Approving; the comments are about reusing the existing DappLogo and store selectors rather than copying them, plus a question about the first lint suppression of its kind in the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #2456 (which is on #2453); retarget to
mainonce those merge.Folder rows now show what's inside at a glance: up to three dApp logos, overlapped like
ChainIconStack, then a "+N" chip for the rest, next to the existing "N dApps" count.DappLogoStackin Discover (ChainIconStacktakes chain ids, so it can't be reused as is).FolderRowItemnow carries the first logos.Related Issues
Checklist
Contract Changes
FolderRowItemgainslogos;useFavoritesSectionreturnsfavoriteLogos. No store or persisted shape change.Behavior Changes