Skip to content

feat(discover): stacked dApp logos on folder rows [PER-2760] - #2457

Open
yasincaliskan wants to merge 2 commits into
yasincaliskan/per-2760-discover-add-to-folder-one-tapfrom
yasincaliskan/per-2760-discover-folder-logos
Open

yasincaliskan wants to merge 2 commits into
yasincaliskan/per-2760-discover-add-to-folder-one-tapfrom
yasincaliskan/per-2760-discover-folder-logos

Conversation

@yasincaliskan

Copy link
Copy Markdown
Collaborator

Description

Stacked on #2456 (which is on #2453); retarget to main once those merge.

Folder rows now show what's inside at a glance: up to three dApp logos, overlapped like ChainIconStack, then a "+N" chip for the rest, next to the existing "N dApps" count.

  • Folder rows on the Discover home and the All folders screen use the folder's own order.
  • The All favorites row shows the newest favorites first, as its screen does.
  • A dApp without a logo shows the globe placeholder; an empty folder shows the count only.
  • New DappLogoStack in Discover (ChainIconStack takes chain ids, so it can't be reused as is). FolderRowItem now carries the first logos.

Related Issues

  • Linear PER-2760

Checklist

  • Tested locally on the iOS simulator: All favorites shows 3 logos, +2 and "5 dApps"; DeFi shows 2 logos and "2 dApps".
  • Tests: the +N rule, folder logos in folder order, All favorites logos newest first, and All folders integration (3 logos and +1 for four dApps, nothing for an empty folder).

Contract Changes

  • FolderRowItem gains logos; useFavoritesSection returns favoriteLogos. No store or persisted shape change.

Behavior Changes

  • Multichain builds: folder rows and All favorites show stacked dApp logos next to the count.
  • Algorand-only builds: no change.

@yasincaliskan
yasincaliskan requested a review from a team as a code owner November 16, 2026 14:31
@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

PER-2760

@github-actions

Copy link
Copy Markdown

Device e2e flows affected

1 suite (3 scenarios, 1 p0): discover

Suite Why
discover module discover

Run them:

  • BrowserStack: the E2E / BrowserStack workflow with include = discover
  • A device: e2e/tools/run.sh <android|ios> --include discover

@yasin-ce yasin-ce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a stacked dApp logo preview (up to three logos, then a +N chip) to folder rows and the All favorites row. It matches the description and is covered by unit and integration tests. Approving; the comments are about reusing the existing DappLogo and store selectors rather than copying them, plus a question about the first lint suppression of its kind in the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants