Repository navigation
fix(history): keep the wallet's own EVM sends listed when the history read fails, and name the failed network beside them [PER-3031] - #2458
Open
filipetamota wants to merge 1 commit into
Open
filipetamota wants to merge 1 commit into
filipetamota wants to merge 1 commit into
Conversation
… read fails, and name the failed network beside them
Device e2e flows affected9 suites (105 scenarios, 26 p0):
Run them:
|
yasin-ce
approved these changes
Nov 16, 2026
yasin-ce
left a comment
Collaborator
There was a problem hiding this comment.
Moves the wallet's own EVM sends out of the backend pages into their own ledger query, merged on read, so a failed history read no longer hides a stuck send. Failed refreshes show a shared notice above the rows. The design is sound and the coverage is thorough: specs for each failure type, the retry target and an integration flow. CI is green.
Nothing blocking. A few questions on the ledger read's now-unused listedIds/cap semantics, and on how the new notice behaves for networks without the service and for transient refresh failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
When the History backend call failed for an EVM account (an outage, a rate limit, or a network with no Pera history service), the whole list errored and the wallet's own open sends disappeared with it, so a send stuck behind a nonce gap had no row, no Waiting on an earlier transaction notice and no way to Unblock, speed up or cancel it [PER-3031].
usePendingTransactionRecordsQuery, SQLite only, re-read on every ledger change) and merged on read intouseTransactionRecordsQuery, so a failed backend read never takes them away; backend pages now hold only the backend's records (getMinedTransactionHistory), and when the backend lists a send, its own row wins over the ledger's.isRefreshFailed(a later page's failure is left to the list), and both Account History and the asset transaction list show a shared HistoryFailedNotice, Couldn't load transactions on Ethereum, above the rows instead of the full-screen error.useAccountHistorydrops under the 300-line limit by moving its filter sheet and CSV export intouseAccountHistoryFilteranduseAccountHistoryCsvExport, with no behaviour change.Covered by specs for the ledger query, the merge function and the records query for each failure (network error, 5xx, PeraServiceUnavailableError, recovery without a duplicate row, a send made after a good load), the rows hook flags and retry target, mergeHistoryFeeds and the notice hook, plus an integration flow rendering History with a send stuck behind a dropped nonce while the history read fails, and device QA against a mocked failing backend.
Related Issues
Closes https://linear.app/algorandfoundation/issue/PER-3031/show-the-wallets-own-pending-evm-sends-in-history-when-the-backend
Checklist
Additional Notes