[BUGFIX] Queries referencing DatasourceVariable couldn't be saved for multiple datasources #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
…on definitions Signed-off-by: AntoineThebaud <antoine.thebaud@yahoo.fr>
AntoineThebaud
force-pushed
the
antoinethebaud/cue-common-ds
branch
from
ce741f8 to
b301211
Compare
AntoineThebaud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ClickHouse, Loki & Pyroscope datasources are currently not compatible with DatasourceVariable on the backend side (= dashboard save gets denied) and need the same fix as what was done here at the time for Prom & Tempo.
Originally this PR was only about refactoring as it follows perses/shared#46 -⚠️ need this /shared change to be released first - so it also includes:
#baseHTTPDatasourceSpecto avoid redefining thedirectUrl | proxydisjunction on plugin side everytime.#selectorto avoid duplicating thevar string | structdisjunction on plugins side.Having all the datasources relying on the same, standard definitions should help in future to avoid "partial" fixes like what happened here.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.