Skip to content

Spoc 481 (step 2): Extend DISCARDFILE coverage to UPDATE, DELETE, and SQL/DDL operations #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danolivo wants to merge 5 commits into from
Closed

Spoc 481 (step 2): Extend DISCARDFILE coverage to UPDATE, DELETE, and SQL/DDL operations #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4360ca6
Add DISCARDFILE support for TRANSDISCARD exception handling
danolivo Mar 17, 2026
bb07a26
Skip per-row exception logging in handle_insert
danolivo Mar 19, 2026
51b832f
Extend DISCARDFILE to cover UPDATE, DELETE, and SQL operations
danolivo Mar 18, 2026
c446537
SUB_DISABLE: allow transaction re-apply after subscription re-enable
danolivo Mar 19, 2026
2dc8985
TRANSDISCARD/SUB_DISABLE: use read-only replay instead of abort/restart
danolivo Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions include/spock_exception_handler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ typedef struct SpockExceptionLog
HeapTuple local_tuple;
char initial_error_message[1024];
char initial_operation[16];
XLogRecPtr failed_lsn;
} SpockExceptionLog;

typedef enum SpockExceptionBehaviour
Expand Down Expand Up @@ -99,4 +100,11 @@ extern void spock_disable_subscription(SpockSubscription *sub,
XLogRecPtr lsn,
TimestampTz ts);

extern bool discardfile_write(const char *node_name, SpockRelation *rel,
Oid remote_origin, Oid local_origin,
const char *operation, SpockTupleData *oldtup,
SpockTupleData *newtup,
TransactionId remote_xid,
const char *ddl_sql, const char *ddl_user);

#endif /* SPOCK_EXCEPTION_HANDLER_H */
3 changes: 3 additions & 0 deletions include/spock_worker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ typedef struct SpockContext
/* Manages access to SpockGroupHash */
LWLock *apply_group_master_lock;

/* DISCARDFILE: lock for concurrent append by apply workers */
LWLock *discard_file_lock;

/* Background workers. */
int total_workers;
SpockWorker workers[FLEXIBLE_ARRAY_MEMBER];
Expand Down
3 changes: 3 additions & 0 deletions sql/spock--6.0.0-devel.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ CREATE TABLE spock.exception_status_detail (
REFERENCES spock.exception_status
) WITH (user_catalog_table=true);

CREATE OR REPLACE FUNCTION spock.discard_read()
RETURNS SETOF jsonb VOLATILE LANGUAGE c AS 'MODULE_PATHNAME', 'spock_discard_read';

CREATE FUNCTION spock.apply_group_progress (
OUT dbid oid,
OUT node_id oid,
Expand Down
Loading
Loading