fix: create SCIM token dialog closing prematurely#906
Merged
Conversation
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
nimish-ks
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where creating the first SCIM token caused the create-token dialog to close instantly, hiding the token before the user could copy it.
Root cause
SCIMPagerendered two separateCreateSCIMTokenDialoginstances — one in the section header (shown when tokens exist), and a duplicate inside theEmptyState(shown only whentokens.length === 0). Creating the first token triggered a refetch that flipped the count from 0 → 1, unmounting theEmptyStatebranch and tearing down the open dialog along with itscreatedTokenstate. On the second attempt, the persistent header dialog was used, so the token displayed correctly.Fix
CreateSCIMTokenDialogto aforwardRefcomponent exposingopenModal/closeModalviauseImperativeHandle, with no built-in trigger button.createTokenDialogRef.createTokenDialogRef.current?.openModal()on the same persistent dialog.The dialog now survives the 0 → 1 token transition, so the newly created token stays visible and copyable.
Preview
Before
Screencast.From.2026-06-01.21-00-13.mp4
After
Screencast.From.2026-06-01.21-13-48.mp4
Review Focus
SCIM:updatepermission.