Conversation
- Git panel tab now always visible on desktop apps even for non-git projects, showing Init/Clone buttons - Removed Find in Files button from the Tools default panel launcher - Shell dropdown now appended to terminal body to avoid overflow clipping from the tab bar
Route all keyboard events to the terminal when it has focus instead of whitelisting individual keys. Only Command Palette (Ctrl+P) and F4 are passed back to Phoenix. Removed redundant EDITOR_SHORTCUTS from TerminalInstance.js — single source of truth is now PHOENIX_SHORTCUTS in main.js.
Replace hardcoded PHOENIX_SHORTCUTS and EDITOR_SHORTCUTS with a dynamic set built from KeyBindingManager bindings for VIEW_TERMINAL and CMD_KEYBOARD_NAV_UI_OVERLAY. Rebuilds automatically when user changes keybindings. Extract logic into _setupPhoenixShortcuts().
Add icon support to bottom panel tabs via options object in createBottomPanel(). Tabs collapse to icons when the tab bar overflows. Supports both FA icon classes and SVG image paths. Panels without icons get a generic fallback icon. Uses panel-titlebar-icon class to override FA specificity issues.
Add more padding and margin between the tab icon and close button when the tab bar is in collapsed/icon mode to prevent accidental close clicks.
The setVisible(true) call in disable("not-repo") changed toolbar
icon behavior and broke git integration tests. Git visibility in
the Tools launcher is already handled by DefaultPanelView.
Use visibility:hidden so inactive tabs keep their spacing but prevent accidental close clicks. Users must activate a tab first before closing it when in collapsed mode.
Extract drag-and-drop into _initDragAndDrop() with vertical line indicator matching file tab bar UX. Fix Tools button losing click handler after tab rebuild by using detach() before empty(). Show tooltip on hover in collapsed icon mode only.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, we had terminal passing phoenix shortcuts to phcode, but this let for eg,
ctrl-Bin tmux in terminal causing bold in the editor which makes some terminal apps unusable. so for best UX just pass all keyboard events except switch terminalf4and command palettectrl-pto terminal.