Skip to content

- Added testing for Container factories for correct option parameters #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
simon-mundy wants to merge 2 commits into
base: 0.2.x
Choose a base branch
from
Open

- Added testing for Container factories for correct option parameters #45

simon-mundy wants to merge 2 commits into from

Conversation

@simon-mundy
Copy link
Contributor

@simon-mundy simon-mundy commented Feb 10, 2026

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA yes
House Keeping yes

Description

Fixed failing tests where the containers needed a requestName and correct options supplied as an array

Additional for discussion

  • TableGatewayTests seem not to be querying correctly. 'isBuffered' is never queried in the ResultSet, and count() cannot be reliably with a ResultSet if the entire resultset is not buffered
  • Another test for invalid namedParam does not work as it bypasses a check

@simon-mundy
- Added testing for Container factories for correct option parameters
6a8358d 
- Marked incomplete tests for discussion

Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
@simon-mundy
- Added Transaction tests for additional coverage
e137e2d 
Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyrsson tyrsson tyrsson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simon-mundy @tyrsson