ext/zlib: minor internal changes. #20654
Draft
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devnexen
commented
Dec 5, 2025
devnexen
commented
- consolidate encoding error exception b/w inflate_init()/deflate_init().
- dictionary option is supposed to be packed.
- consolidate encoding error exception b/w inflate_init()/deflate_init(). - dictionary option is supposed to be packed.
ndossche
reviewed
Dec 9, 2025
| HashTable *dictionary = Z_ARR_P(option_buffer); | ||
| bool result = true; | ||
|
|
||
| if (!HT_IS_PACKED(dictionary)) { |
Member
There was a problem hiding this comment.
It's possible to have a non-packed array that only has integer keys. So this check is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.