Document ResourceStream close behavior#52
Merged
veewee merged 1 commit intophpro:v2.xfrom Apr 7, 2026
Merged
Conversation
The underlying PHP resource is shared between the ResourceStream and the PSR-7 stream, so closing one closes the other. Document this and suggest copying the stream when reuse is needed.
veewee
force-pushed
the
resource-stream-close-docs
branch
from
c150697 to
0785ded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourceStreamEncodershares the underlying PHP resource with PSR-7, soStreamInterface::close()also closes the originalResourceStreamcopyTo(MemoryStream::create())) when reuse after sending a request is needed