Repository navigation
Missing engines Field Update for Node.js Version Support in v2.0.0 #64
Description
Hi finalhandler maintainers,
I noticed in the changelog for the latest release (v2.0.0) that there is a breaking change which states:
drop support for node <18
However, it seems that the package.json engines field was not updated to reflect this change.
Would it be possible to update the engines field in package.json to explicitly specify the range of supported Node.js versions? This would greatly help in ensuring compatibility when upgrading to finalhandler v2.0.0.
Thank you for all your hard work on this project!
Activity
fix: update engines field to reflect supported node versions
wesleytodd commentedon Jan 16, 2025
Yeah we can do this. We decided to add it as a minor in a few other packages because it was missed in the initial release. While it is technically a breaking change, it's omission was an oversight and so aligns with the policy we have set.
Phillip9587 commentedon Jan 16, 2025
There already is PR #59 for this change.
wesleytodd commentedon Jan 16, 2025
Oh cool, I forgot about that one. Lets close this then and use that for any further discussion.