Fix three schema mismatch bugs under disaggregated arch by gengliqi · Pull Request #10530 · pingcap/tiflash

gengliqi · 2025-11-06T19:37:54Z

What problem does this PR solve?

Issue Number: close #10226, #10211

Problem Summary:
Three schema mismatch bugs

time type Query fails under disaggregated arch #10211, covered by fullstack-test-index/inverted/datetime-type.test
generated column Query fails under disaggregated arch #10226, covered by fullstack-test/mpp/generated_column.test and fullstack-test/expr/generated_columns2.test
extra table id, covered by fullstack-test/mpp/extra_physical_table_column.test

What is changed and how it works?

Fix three schema mismatch bugs under disaggregated arch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Fix three schema mismatch bugs under disaggregated arch

Signed-off-by: gengliqi <gengliqiii@gmail.com>

JaySon-Huang · 2025-11-07T02:05:05Z

/run-pull-integration-next-gen

JaySon-Huang · 2025-11-07T02:05:25Z

/test pull-integration-next-gen

Signed-off-by: gengliqi <gengliqiii@gmail.com>

JaySon-Huang

Rest LGTM

dbms/src/Storages/StorageDisaggregatedRemote.cpp

tests/fullstack-test/expr/unixTimeStamp.test

Signed-off-by: gengliqi <gengliqiii@gmail.com>

gengliqi · 2025-11-26T15:27:43Z

/retest

gengliqi · 2025-11-27T06:08:13Z

/cc @JaySon-Huang @windtalker

JaySon-Huang

LGTM

windtalker

lgtm

ti-chi-bot · 2025-12-01T01:17:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-12-01T01:17:36Z

[LGTM Timeline notifier]

Timeline:

2025-11-27 09:05:30.826756677 +0000 UTC m=+780094.475951133: ☑️ agreed by JaySon-Huang.
2025-12-01 01:17:35.145456638 +0000 UTC m=+226199.959234220: ☑️ agreed by windtalker.

gengliqi · 2025-12-01T03:18:37Z

/cherry-pick release-nextgen-20251011

gengliqi · 2025-12-01T03:19:02Z

/cherry-pick release-8.5

ti-chi-bot · 2025-12-01T03:19:14Z

@gengliqi: new pull request created to branch release-nextgen-20251011: #10579.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close pingcap#10226 Fix three schema mismatch bugs under disaggregated arch Signed-off-by: gengliqi <gengliqiii@gmail.com>

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-12-01T03:19:41Z

@gengliqi: new pull request created to branch release-8.5: #10580.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

) close #10226 Fix three schema mismatch bugs under disaggregated arch Signed-off-by: gengliqi <gengliqiii@gmail.com> Co-authored-by: Liqi Geng <gengliqiii@gmail.com>

close pingcap#10226 Fix three schema mismatch bugs under disaggregated arch Signed-off-by: gengliqi <gengliqiii@gmail.com>

gengliqi added 6 commits October 13, 2025 19:44

fix

cf5dc45

Signed-off-by: gengliqi <gengliqiii@gmail.com>

fix more bugs

892e01e

Signed-off-by: gengliqi <gengliqiii@gmail.com>

fix the generated column bug

b745969

Signed-off-by: gengliqi <gengliqiii@gmail.com>

merge master

8b558e5

Signed-off-by: gengliqi <gengliqiii@gmail.com>

enable next-gen tests for expr and mpp

160b035

Signed-off-by: gengliqi <gengliqiii@gmail.com>

enable more tests

d6e0a47

Signed-off-by: gengliqi <gengliqiii@gmail.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2025

gengliqi added 3 commits November 7, 2025 14:17

add tikv-worker for next-gen tests

45875ac

Signed-off-by: gengliqi <gengliqiii@gmail.com>

add license

5eadeaa

Signed-off-by: gengliqi <gengliqiii@gmail.com>

u

8ab0b88

Signed-off-by: gengliqi <gengliqiii@gmail.com>

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Nov 18, 2025

gengliqi added 6 commits November 18, 2025 16:52

update tikv-worker.toml

1d23e5e

Signed-off-by: gengliqi <gengliqiii@gmail.com>

update tidb.toml

fda22b2

Signed-off-by: gengliqi <gengliqiii@gmail.com>

update tidb.toml

cb326d5

Signed-off-by: gengliqi <gengliqiii@gmail.com>

update tikv.toml

90fa537

Signed-off-by: gengliqi <gengliqiii@gmail.com>

update tikv.toml again

dfe784e

Signed-off-by: gengliqi <gengliqiii@gmail.com>

disable unixTimeStamp.test for next-gen

f269ba2

Signed-off-by: gengliqi <gengliqiii@gmail.com>

gengliqi requested review from JaySon-Huang and windtalker November 18, 2025 12:09

u

2378d5f

Signed-off-by: gengliqi <gengliqiii@gmail.com>

JaySon-Huang reviewed Nov 26, 2025

View reviewed changes

dbms/src/Storages/StorageDisaggregatedRemote.cpp Outdated Show resolved Hide resolved

tests/fullstack-test/expr/unixTimeStamp.test Outdated Show resolved Hide resolved

address comments

39459a1

Signed-off-by: gengliqi <gengliqiii@gmail.com>

ti-chi-bot bot requested a review from JaySon-Huang November 27, 2025 06:08

JaySon-Huang approved these changes Nov 27, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 27, 2025

windtalker approved these changes Dec 1, 2025

View reviewed changes

ti-chi-bot bot added the lgtm label Dec 1, 2025

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 1, 2025

ti-chi-bot bot merged commit a5e1403 into pingcap:master Dec 1, 2025
7 checks passed

ti-chi-bot mentioned this pull request Dec 1, 2025

Fix three schema mismatch bugs under disaggregated arch (#10530) #10579

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 1, 2025

This is an automated cherry-pick of pingcap#10530

8d69295

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Dec 1, 2025

Fix three schema mismatch bugs under disaggregated arch (#10530) #10580

Open

12 tasks

JaySon-Huang mentioned this pull request Dec 1, 2025

Query fails under disaggregated arch #10211

Closed

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 1, 2025

wshwsh12 pushed a commit to wshwsh12/tiflash that referenced this pull request Feb 9, 2026

Fix three schema mismatch bugs under disaggregated arch (pingcap#10530)

788b4cc

close pingcap#10226 Fix three schema mismatch bugs under disaggregated arch Signed-off-by: gengliqi <gengliqiii@gmail.com>

Conversation

gengliqi commented Nov 6, 2025 • edited by JaySon-Huang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

JaySon-Huang commented Nov 7, 2025

Uh oh!

JaySon-Huang commented Nov 7, 2025

Uh oh!

JaySon-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gengliqi commented Nov 26, 2025

Uh oh!

gengliqi commented Nov 27, 2025

Uh oh!

JaySon-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Dec 1, 2025

Uh oh!

ti-chi-bot bot commented Dec 1, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

gengliqi commented Dec 1, 2025

Uh oh!

gengliqi commented Dec 1, 2025

Uh oh!

ti-chi-bot commented Dec 1, 2025

Uh oh!

ti-chi-bot commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gengliqi commented Nov 6, 2025 •

edited by JaySon-Huang

Loading