Repository navigation
fix: preserve wrapped retry client attributes - #654
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryingClient currently returns a callable for every attribute lookup. As a result, reading
client.ignore_excreturns a truthy function instead of False, readingclient.serverloses the server tuple, andhasattr(client, "missing_method")incorrectly returns True.Resolve the wrapped attribute first, return non-callable values unchanged, and apply retries only to callable attributes. Missing attributes now raise AttributeError at lookup time, matching the underlying client.
Four new regression cases fail before the fix. All 61 retry-client tests pass afterward, including the existing retry and exception-filter tests. Black 24.4.2, Flake8 7.1.1, and diff whitespace checks pass.
The wider Windows unit run has 494 passed, one skipped, and three failures that also reproduce with the original retry module (Unix socket support and two zero-timeout hash-client tests). The compression module was excluded because its native zstd dependency could not be built on this machine. Live memcached integration tests were not run.