Repository navigation
Fix _readsegment dropping bytes read before end_tokens - #661
Open
malanore-z wants to merge 1 commit into
Open
malanore-z wants to merge 1 commit into
malanore-z wants to merge 1 commit into
Conversation
_readsegment overwrote its buffer on each _recv(), discarding bytes read while the end_tokens had not appeared yet. This made raw_command return truncated responses when a reply arrived split across multiple socket reads. Accumulate the bytes read so far before reading more, matching _readline and _readvalue, and add a regression test.
Author
|
@jparise Hi, sorry to bother you. I've noticed this PR has been open for three weeks. Could you please take a look when you have some time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_readsegment overwrote its buffer on each _recv(), discarding bytes read while the end_tokens had not appeared yet. This made raw_command return truncated responses when a reply arrived split across multiple socket reads. Accumulate the bytes read so far before reading more, matching _readline and _readvalue, and add a regression test.