Repository navigation
Reject ASCII control characters in cache keys - #664
Open
blouirts123 wants to merge 1 commit into
Open
blouirts123 wants to merge 1 commit into
blouirts123 wants to merge 1 commit into
Conversation
blouirts123
marked this pull request as draft
October 16, 2026 04:51
blouirts123
marked this pull request as ready for review
October 16, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_key_helperaccepts non-whitespace ASCII controls such as SOH and DEL, although the Client API and memcached key protocol prohibit control characters. Reject them before a connection is opened, with regressions for byte/string keys and the Client.set path. High-byte raw keys and UTF-8 behavior remain covered.This complements #663's whitespace-only key case.
Validation on Windows Python 3.14: nine focused tests pass, including an independent rerun; 496 unit tests pass with one existing skip and the known Unix-socket test excluded. That Unix-socket failure also reproduces on the clean base. Flake8 and changed-file formatting checks pass. No live memcached daemon was used; these checks establish the client-side validation contract.