Fix memory leak with nackCountLogs #386
Merged
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipch07
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 79.45% 79.70% +0.25%
==========================================
Files 84 84
Lines 4176 4179 +3
==========================================
+ Hits 3318 3331 +13
+ Misses 685 678 -7
+ Partials 173 170 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This doesn't fix the deadlock problem from #384, but I think I just found it. I'll make a new pr for that (it's based on this pr though). |
philipch07
force-pushed
the
pch07/fix-nackcountlogs-mem
branch
from
c001ab2 to
0a69b6c
Compare
philipch07
force-pushed
the
pch07/fix-nackcountlogs-mem
branch
from
0a69b6c to
d12daa5
Compare
This was referenced Dec 1, 2025
Sean-Der
approved these changes
Dec 2, 2025
Member
Sean-Der
left a comment
Sean-Der
left a comment
There was a problem hiding this comment.
Dang nice debugging/catch @philipch07!
JoTurk
approved these changes
Dec 2, 2025
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Yeah, as I promised to test it again when i wake up it's working as intended 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nackCountLogswasn't getting cleaned up properly ingenerator_interceptor.gofrom the nack package.this is fixed in two ways:
UnbindRemoteStream()can delete the respectivenackCountLogsfor the providedSSRC.loop()we can drop thenackCountLogsmap if it's empty. This is particularly helpful if a lot of them get accumulated over time.Reference issue
#328 and @joeturki mentioned that there were reports of a memory leak so hopefully this fixes it.