Repository navigation
Combobox improvements - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't expect this to get a thorough review so it's a bit of an omnibus including some things I've noticed and also an attempt to unblock @zoldar
API changes
namefield from.combobox_inputto.comboboxphx-changewithon_search. Backend event handler now receives%{"query" => query}. Also changes how loading state is communicated (.phx-hook-loadingon root component instead of.phx-change-loadingon input element).See docstrings in https://github.com/plausible/prima/compare/combobox-improvements?expand=1#diff-b1c3a5096660fe1d0fe91281794b4e74e34f614fdb3dced0c6c98980d52f259d for details
Contains a bunch of bug fixes along with these changes.