Repository navigation
Use LiveView focus stack and mount binding for modals - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modals with
show={true}currently replay their opening logic on updates and reconnects, which can reopen a dismissed modal and overwrite the saved focus target and body scroll styles.Use
phx-mountedfor initial visibility and LiveView'sJS.push_focus/JS.pop_focusfor focus restoration. Ignore repeated opens and share guarded cleanup between the end of the hide transition and removal of an open modal. Body scrolling stays locked until the close transition finishes.Consolidate overlapping modal tests while covering initial visibility, rerenders, reconnects, repeated opens, backend open/close, and removal cleanup.